Patch Set 4:

(1 comment)

Patch Set 4:

(3 comments)

haven't checked the register numbers, but didn't spot anything that should be different after the preprocessor run. what i'd suggest you to try would be running the preprocessor on the files before and after the patch and diff the result; i'd expect that there's some typo in a register number or wrong register replacement

Good idea, thanks for the tip. I compared the object files, and the size of romstage raminit_common.o is sliiightly larger. I wonder why.

In any case, I'm going to grab all my sandy/ivy boards to boot test these changes with.

View Change

To view, visit change 38036. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e5fe56eaa90842dbbdd1bfbbcb7709237b4c486
Gerrit-Change-Number: 38036
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 02 Jan 2020 21:57:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment