View Change
1 comment:
Commit Message:
Patch Set #7, Line 12: the log level will be set to CONFIG_DEFAULT_CONSOLE_LOGLEVEL.
So I should move the get_console_loglevel() into get_option() to unify the function interface, right […]
In order to set log level before POST CAR, on Cooper Lake I can remove the check for CONSOLE_LEVEL_CONST and let init_log_level() set the log level, not sure if it works for other platforms/architectures. Or maybe add an option for allowing changing log level before POST CAR and default set to n.
To view, visit change 45134. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278e392bed178df7a8cdb90685963c1fedf0bcc4
Gerrit-Change-Number: 45134
Gerrit-PatchSet: 10
Gerrit-Owner: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang@wiwynn.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: insomniac <insomniac@slackware.it>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 19 Sep 2020 05:28:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin <Johnny_Lin@wiwynn.com>
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment