FYI: I had a look at this patch some time ago and commented on some things in a chat with siro. I don't really remember what my comments were though...

Have you asked siro about this? There were quite a few things. might have a look if i still have the chat logs about this

View Change

To view, visit change 32334. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib477bd332984c397289404cfc33c65a2d4469257
Gerrit-Change-Number: 32334
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <>
Gerrit-Reviewer: Alexander Couzens <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: Arthur Heymans <>
Gerrit-Reviewer: Christian Walter <>
Gerrit-Reviewer: Felix Held <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Tue, 26 May 2020 13:07:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment