As the commit message and Andrey point out this is from an engineering build and is likely to change. I don't think we've done much active development on FSP after it's committed to src/vendorcode, but I also don't think there's a rule or a reason not to (aside from people's preferences).

Anyway, I'm fine with putting these files here so they stick to convention of placing FSP headers. Patrick?

Patch set 1:Code-Review +1

View Change

To view, visit change 39108. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If47f102c2c7979da1196f8c6b315d5be558e786c
Gerrit-Change-Number: 39108
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Andrey Petrov <anpetrov@fb.com>
Gerrit-Comment-Date: Tue, 25 Feb 2020 19:37:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment