[coreboot-gerrit] [S] Change in coreboot[main]: vendorcode/google/chromeos: API to read factory config

[Paul Menzel (Code Review)]

Attention is currently required from: Nick Vaccaro, Shelley Chen, Subrata Banik, Tim Van Patten.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: vendorcode/google/chromeos: API to read factory config
......................................................................

Patch Set 5:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/79737/comment/028a9c4a_31edd23b :
PS5, Line 7: API to read factory config
Please make it a statement:
> Add …

File src/vendorcode/google/chromeos/chromeos.h:

https://review.coreboot.org/c/coreboot/+/79737/comment/0d295784_88848f15 :
PS5, Line 31:  * For the unprovisioned one, the read will be 0x0.
0 is also returned in the error case?

File src/vendorcode/google/chromeos/tpm_factory_config.c:

https://review.coreboot.org/c/coreboot/+/79737/comment/6d5dc792_6dad15a4 :
PS5, Line 12: 		printk(BIOS_ERR, "tlcl_lib_init() failed: %#x\n", rc);
As this is an error message, please elaborate for a user reading the log.

https://review.coreboot.org/c/coreboot/+/79737/comment/65be1c7f_00687caa :
PS5, Line 21: 		printk(BIOS_ERR, "tlcl_cr50_get_factory_config() failed: %#x\n", rc);
Ditto.