Patrick Georgi merged this change.

View Change

vc/cavium/bdk/libbdk-hal: Fix eye data memory leak

This function can capture and allocate its own eye data, so in that case
set need_free to true so it is freed at the end.

Change-Id: I63ca6d743e6610d3e3ab6bd7b0356aabdfa6f784
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1393969
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34591
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
---
M src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c
index f7d631f..b9552d4 100644
--- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c
+++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c
@@ -362,9 +362,12 @@
             bdk_error("Failed to allocate space for eye\n");
             return -1;
         }
-        if (bdk_qlm_eye_capture(node, qlm, qlm_lane, eye_data))
-            return -1;
+        if (bdk_qlm_eye_capture(node, qlm, qlm_lane, eye_data)) {
+	    free(eye_data);
+	    return -1;
+	}
         eye = eye_data;
+	need_free = 1;
     }
 
     /* Calculate the max eye width */

To view, visit change 34591. To unsubscribe, or for help writing mail filters, visit settings.