Patrick Georgi submitted this change.

View Change

mb/google/volteer: Select SOC_INTEL_CSE_LITE_SKU for volteer baseboard

This change moves the selection of SOC_INTEL_CSE_LITE_SKU into Kconfig
under BOARD_GOOGLE_BASEBOARD_VOLTEER instead of requiring each
individual board to select it.

TEST=Verified that timeless build does not result in any changes.

Change-Id: I2d94931fdc3077794bed5cc51708b5a5d9e64972
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50096
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
2 files changed, 2 insertions(+), 17 deletions(-)

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index e529c7a..3217d07 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -31,6 +31,7 @@
 	select MAINBOARD_HAS_I2C_TPM_CR50 if BOARD_GOOGLE_VOLTEER2_TI50
 	select MAINBOARD_HAS_TPM2
 	select PCIEXP_HOTPLUG
+	select SOC_INTEL_CSE_LITE_SKU
 	select SOC_INTEL_TIGERLAKE
 	select HAVE_SPD_IN_CBFS
 
@@ -39,7 +40,7 @@
 config CHROMEOS
 	bool
 	default y
-	select CHROMEOS_CSE_BOARD_RESET_OVERRIDE if SOC_INTEL_CSE_LITE_SKU
+	select CHROMEOS_CSE_BOARD_RESET_OVERRIDE
 	select CHROMEOS_DRAM_PART_NUMBER_IN_CBI
 	select EC_GOOGLE_CHROMEEC_SWITCHES
 	select GBB_FLAG_FORCE_DEV_SWITCH_ON
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index 292ab3e..5bb1794 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -3,24 +3,20 @@
 config BOARD_GOOGLE_DELBIN
 	bool "-> Delbin"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 	select DRIVERS_GENESYSLOGIC_GL9755
 
 config BOARD_GOOGLE_ELDRID
 	bool "-> Eldrid"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 
 config BOARD_GOOGLE_HALVOR
 	bool "-> Halvor"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 	select INTEL_CAR_NEM
 
 config BOARD_GOOGLE_LINDAR
 	bool "-> Lindar"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 	select INTEL_CAR_NEM
 	select CHROMEOS_DSM_CALIB if CHROMEOS
 	select DRIVERS_I2C_RT1011
@@ -28,38 +24,32 @@
 config BOARD_GOOGLE_MALEFOR
 	bool "-> Malefor"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 	select INTEL_CAR_NEM
 
 config BOARD_GOOGLE_TERRADOR
 	bool "-> Terrador"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 
 config BOARD_GOOGLE_TODOR
 	bool "-> Todor"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 	select INTEL_CAR_NEM
 
 config BOARD_GOOGLE_TRONDO
 	bool "-> Trondo"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 	select INTEL_CAR_NEM
 
 config BOARD_GOOGLE_VOLTEER
 	bool "-> Volteer"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
 	select VARIANT_HAS_MIPI_CAMERA
-	select SOC_INTEL_CSE_LITE_SKU
 	select INTEL_CAR_NEM
 
 config BOARD_GOOGLE_VOLTEER2
 	bool "-> Volteer2"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
 	select VARIANT_HAS_MIPI_CAMERA
-	select SOC_INTEL_CSE_LITE_SKU
 	select DRIVERS_GENESYSLOGIC_GL9755
 	select DRIVER_I2C_TPM_ACPI
 
@@ -68,33 +58,27 @@
 	bool "-> Volteer2_Ti50"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
 	select VARIANT_HAS_MIPI_CAMERA
-	select SOC_INTEL_CSE_LITE_SKU
 	select DRIVERS_GENESYSLOGIC_GL9755
 	select DRIVER_I2C_TPM_ACPI
 
 config BOARD_GOOGLE_VOXEL
 	bool "-> Voxel"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 
 config BOARD_GOOGLE_ELEMI
 	bool "-> Elemi"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU
 
 config BOARD_GOOGLE_VOEMA
 	bool "-> Voema"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
 	select VARIANT_HAS_MIPI_CAMERA
-	select SOC_INTEL_CSE_LITE_SKU
 
 config BOARD_GOOGLE_DROBIT
 	bool "-> Drobit"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
 	select DRIVERS_GENESYSLOGIC_GL9755
-	select SOC_INTEL_CSE_LITE_SKU
 
 config BOARD_GOOGLE_COPANO
 	bool "-> Copano"
 	select BOARD_GOOGLE_BASEBOARD_VOLTEER
-	select SOC_INTEL_CSE_LITE_SKU

To view, visit change 50096. To unsubscribe, or for help writing mail filters, visit settings.