Attention is currently required from: Arthur Heymans, Felix Singer, Jakub Czapiga.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 10:
This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
> I think the intent is really to enable editors recognizing them as a make file. .mk and . […]
I didn't try emacs. my editors recognize the .mak extension by default.
if someone wants to do the work to change the patches to .mk, they're welcome to take over the patch train. that's not said with any bitterness, but I already did the work and switched to .mak, and that works for me.
The issue that this patch series is attempting to fix is that .inc is very ambiguous. .mak is not.
To view, visit change 80063. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Jakub Czapiga <czapiga@google.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Comment-Date: Sat, 20 Jan 2024 19:52:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-MessageType: comment