View Change

14 comments:

• File src/soc/qualcomm/qcs405/qclib_execute.c:

  • Patch Set #2, Line 35: int (*doit)(void *, void *);

    function definition argument 'void *' should also have an identifier name

  • Patch Set #2, Line 35: int (*doit)(void *, void *);

    function definition argument 'void *' should also have an identifier name

  • Patch Set #2, Line 43: struct prog pmic =

    code indent should use tabs where possible

  • Patch Set #2, Line 43: struct prog pmic =

    please, no spaces at the start of a line

  • Patch Set #2, Line 44: PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX PMIC_NAME);

    code indent should use tabs where possible

  • Patch Set #2, Line 44: PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX PMIC_NAME);

    please, no spaces at the start of a line

  • Patch Set #2, Line 52: if (prog_locate(&pmic))

    code indent should use tabs where possible

  • Patch Set #2, Line 52: if (prog_locate(&pmic))

    please, no spaces at the start of a line

  • Patch Set #2, Line 53: goto fail;

    code indent should use tabs where possible

  • Patch Set #2, Line 53: goto fail;

    please, no spaces at the start of a line

  • Patch Set #2, Line 55: if (cbfs_prog_stage_load(&pmic))

    code indent should use tabs where possible

  • Patch Set #2, Line 55: if (cbfs_prog_stage_load(&pmic))

    please, no spaces at the start of a line

  • Patch Set #2, Line 56: goto fail;

    code indent should use tabs where possible

  • Patch Set #2, Line 56: goto fail;

    please, no spaces at the start of a line

To view, visit change 29967. To unsubscribe, or for help writing mail filters, visit settings.