build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support ......................................................................
Patch Set 2:
(14 comments)
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... File src/soc/qualcomm/qcs405/qclib_execute.c:
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 35: int (*doit)(void *, void *); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 35: int (*doit)(void *, void *); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 43: struct prog pmic = code indent should use tabs where possible
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 43: struct prog pmic = please, no spaces at the start of a line
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 44: PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX PMIC_NAME); code indent should use tabs where possible
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 44: PROG_INIT(PROG_REFCODE, CONFIG_CBFS_PREFIX PMIC_NAME); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 52: if (prog_locate(&pmic)) code indent should use tabs where possible
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 52: if (prog_locate(&pmic)) please, no spaces at the start of a line
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 53: goto fail; code indent should use tabs where possible
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 53: goto fail; please, no spaces at the start of a line
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 55: if (cbfs_prog_stage_load(&pmic)) code indent should use tabs where possible
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 55: if (cbfs_prog_stage_load(&pmic)) please, no spaces at the start of a line
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 56: goto fail; code indent should use tabs where possible
https://review.coreboot.org/#/c/29967/2/src/soc/qualcomm/qcs405/qclib_execut... PS2, Line 56: goto fail; please, no spaces at the start of a line