15 comments:
File src/mainboard/unk/Kconfig:
I'd use "unknown" in symbol and folder names, it's clearer
File src/mainboard/unk/gbyt4/acpi/mainboard.asl:
Patch Set #1, Line 3: Scope (\_SB.PCI0.LPEA)
This is for LPE audio, if the board doesn't have any audio support, then I'd drop it
File src/mainboard/unk/gbyt4/cmos.layout:
Patch Set #1, Line 12: #96 4 r 0 status_c_rsvd
You can drop all commented-out entries. They can only bitrot 😄
The most offensive ones are the "unused" and the last one that says "amd_reserved"
# SandyBridge MRC Scrambler Seed values
896 32 r 0 mrc_scrambler_seed
928 32 r 0 mrc_scrambler_seed_s3
Not Sandy Bridge
File src/mainboard/unk/gbyt4/devicetree.cb:
0x3 is the mask for 2 ports
on
It's the SPI controller where the flash chip sits, AFAIK
space
File src/mainboard/unk/gbyt4/dsdt.asl:
Scope (\_SB) {
Device (PCI0)
{
Ugh, that inconsistent brace placement... After removing unneeded lines, you can have a single set of braces:
Device (\_SB.PCI0)
{
#include <soc/intel/baytrail/acpi/southcluster.asl>
}
Patch Set #1, Line 25: //#include <soc/intel/baytrail/acpi/northcluster.asl>
You can drop this commented-out include
Patch Set #1, Line 27: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
If your board doesn't have an integrated LCD, this can be removed
Patch Set #1, Line 31: #include "acpi/dptf.asl"
Since DPTF is not enabled, you can drop this and remove the file
Patch Set #1, Line 35: #include "acpi/mainboard.asl"
If this file is empty, you can remove this line
File src/mainboard/unk/gbyt4/early_init.c:
I am not sure if this code is being called... To be sure, you can move this to romstage.c, more or less like I did on the Asrock Q1900M:
https://review.coreboot.org/c/coreboot/+/39658/4/src/mainboard/asrock/q1900m/romstage.c#18
File src/mainboard/unk/gbyt4/gpio.c:
Patch Set #1, Line 208: struct soc_gpio_config* mainboard_get_gpios(void)
"foo* bar" should be "foo *bar"
Would be good to fix
File src/mainboard/unk/gbyt4/romstage.c:
Patch Set #1, Line 9: //static void *get_spd_pointer(char *spd_file_content, int total_spds, int *dual)
You know you can comment things using preprocessor, right? 😄
#if 0
/* Tons of spaghetti code */
#endif
To view, visit change 43087. To unsubscribe, or for help writing mail filters, visit settings.