1 comment:
File src/vendorcode/google/chromeos/acpi/chromeos.asl:
Patch Set #2, Line 79: CONFIG_VBOOT_VBNV_OFFSET - 14,
Looks like this code would be added even if !VBOOT_VBNV_CMOS. So if cros […]
I had to think twice about it to figure what my younger self meant here.
The problem is that if VBOOT_VBNV_CMOS is disabled, we had a 0 here. But
after this patch it would be an odd -14.
Maybe it's better to restart this work. First, figure out what this `14`
is about. Why is C code always using that offset but ASL isn't? It's all
not that easy with an unspecified ACPI API (or is it documented somewhere?).
To view, visit change 38918. To unsubscribe, or for help writing mail filters, visit settings.