What’s the difference to `src/ec/quanta/it8518/`?
Patch Set #1, Line 7:
mb/lenovo/x131e: function key support
Please use a statement:
Add function key support
Support function key
The IT8518e EC of this board uses some different ACPI methods compared to the
regular Lenovo H8.
Did you have documentation for that, or did you reverse engineer this?
Patch Set #1, Line 35:
Use alternative EC query methods for X131e
Please also mention the EC.
… using an IT8518e EC.
Shouldn’t this go under `src/ec/…/it…/` like with `src/ec/quanta/it8518/ec.h`?
Patch Set #1, Line 25:
Please add a comment, why this is needed.
To view, visit change 31067. To unsubscribe, or for help writing mail filters, visit settings.