Some of this discussion was split out into CB:35463, let's try to move it back here. Basically, it seems there's agreement that we shouldn't have different APIs for the same thing but we also want something that's not endian-specific, which clrsetbits_le32() currently is.

So to move forward, would anyone object if I:

1. remove this file again (doesn't seem like any code is using this yet),
2. add a new clrsetbits32() (and variants) API for this instead, and
3. change all existing instances of clrsetbits_le32() that don't clearly need the endian-specificness to clrsetbits32()?

View Change

To view, visit change 36596. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f188d586c09ee9f1e17290563f68970603204fb
Gerrit-Change-Number: 36596
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Hung-Te Lin <hungte@chromium.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 27 Nov 2019 21:34:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment