Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41045 )
Change subject: tests: Add <tests/test.h> wrapper header and fix --gc-sections
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41045/1/tests/Makefile.inc
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41045/1/tests/Makefile.inc@41
PS1, Line 41: subdirs:= tests/arch tests/commonlib tests/console tests/cpu tests/device
$(testsrc) is absolute but in all other cases subdirs are defined relative, so I would keep it that […]
Yes, it should work - but OK.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41045
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4284d74c8673708e21a5266eb42f7b9ae19a1b12
Gerrit-Change-Number: 41045
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jan Dabros
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 May 2020 03:13:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Jan Dabros
Gerrit-MessageType: comment