
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Lean Sheng Tan, Matt DeVillier, Nick Vaccaro, Nico Huber, Subrata Banik. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81638?usp=email ) Change subject: intel/alderlake: Add helper functions for Power Management ...................................................................... Patch Set 5: (2 comments) File src/soc/intel/alderlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/81638/comment/50df8d19_63c7e4af : PS3, Line 481: CONFIG(SOC_INTEL_COMPLIANCE_TEST_MODE)
please keep this config for EA testing purpose. Done
File src/soc/intel/alderlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/81638/comment/56c17701_5d351caa : PS4, Line 504: default "auto"
Sorry, my bad, should have explained better. To coreboot, default (e.g. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/81638?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9db18859f9a04ad4b7c0c3f7992b09e0f9484a81 Gerrit-Change-Number: 81638 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean@starlabs.systems> Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan@9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Eric Lai <ericllai@google.com> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Eric Lai <ericllai@google.com> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Subrata Banik <subratabanik@google.com> Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot@google.com> Gerrit-Attention: Kapil Porwal <kapilporwal@google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan@9elements.com> Gerrit-Comment-Date: Mon, 15 Apr 2024 08:58:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai@google.com> Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Sean Rhodes <sean@starlabs.systems> Gerrit-MessageType: comment