[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/xeon_sp: Fix SRAT debug prints

[Patrick Rudolph (Code Review)]

Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85189?usp=email )

Change subject: soc/intel/xeon_sp: Fix SRAT debug prints
......................................................................

soc/intel/xeon_sp: Fix SRAT debug prints

- Drop duplicated fields
- Drop fields filled with constant values
- Drop SRAT prefix for sysmemmap entries
- Print all zeros when concatenating two hex numbers

Change-Id: I379aeb6fcd2e28665c7d592b0639db3c1b4caa9b
Signed-off-by: Patrick Rudolph 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85189
Reviewed-by: Shuo Liu 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/xeon_sp/uncore_acpi.c
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Shuo Liu: Looks good to me, approved

diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c
index 2d0baf9..b64271e 100644
--- a/src/soc/intel/xeon_sp/uncore_acpi.c
+++ b/src/soc/intel/xeon_sp/uncore_acpi.c
@@ -84,9 +84,9 @@
    addr = ((uint64_t)e->BaseAddress << MEM_ADDR_64MB_SHIFT_BITS);
    size = ((uint64_t)e->ElementSize << MEM_ADDR_64MB_SHIFT_BITS);

-	printk(BIOS_DEBUG, "SRAT: sysmemmap addr: 0x%llx, BaseAddress: 0x%x, size: 0x%llx, "
-	       "ElementSize: 0x%x, type: %d, reserved: %d\n", addr, e->BaseAddress,
-	       size, e->ElementSize, e->Type, is_memtype_reserved(e->Type));
+	printk(BIOS_DEBUG, "     sysmemmap addr: 0x%llx, size: 0x%llx, "
+	       "type: %d, reserved: %d\n", addr, size, e->Type,
+	       is_memtype_reserved(e->Type));

/* skip reserved memory region */
    if (is_memtype_reserved(e->Type))
@@ -122,9 +122,9 @@
    }

if (!skip) {
-		printk(BIOS_DEBUG, "SRAT: adding memory %d entry length: %d, addr: 0x%x%x, "
-		       "length: 0x%x%x, proximity_domain: %d, flags: %x\n",
-		       *cnt, srat.length, srat.base_address_high, srat.base_address_low,
+		printk(BIOS_DEBUG, "SRAT: memory %d: addr=0x%x%08x, "
+		       "length=0x%x%08x, proximity_domain=%d, flags=%x\n",
+		       *cnt, srat.base_address_high, srat.base_address_low,
    	       srat.length_high, srat.length_low, srat.proximity_domain, srat.flags);

memcpy(current, &srat, sizeof(acpi_srat_mem_t));