I don't work with this code enough to have a sense of how useful those prints are, so please take my suggestion with a grain of salt.

View Change

3 comments:

• File src/drivers/intel/fsp1_1/raminit.c:

  • Patch Set #9, Line 209:

    Is it be worth preserving these prints in a static display_hob_info() function like in ramstage.c?

  • Patch Set #9, Line 224:

    Same comment as above - Perhaps it's worth preserving these in a display_hob_info() function that gets called if CONFIG(DISPLAY_HOBS) is true.

• File src/drivers/intel/fsp1_1/ramstage.c:

  • Patch Set #9, Line 63: if (CONFIG(DISPLAY_HOBS))

    It feels awkward to call display_hob_info() and check CONFIG(DISPLAY_HOBS) multiple times. Why would we call this function if we don't want to display HOB info?

    How about checking CONFIG(DISPLAY_HOBS) on line 143 before calling this function, and remove the checks from here? I think that makes the code cleaner.

To view, visit change 29371. To unsubscribe, or for help writing mail filters, visit settings.