[coreboot-gerrit] [XS] Change in coreboot[master]: cpu/x86: Reduce scope of MTRR functions used locally

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76193?usp=email )

Change subject: cpu/x86: Reduce scope of MTRR functions used locally
......................................................................

cpu/x86: Reduce scope of MTRR functions used locally

Change-Id: Ic00358ee5b05d011a95d85ec355adef71c39a529
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76193
Reviewed-by: Elyes Haouas 
Tested-by: build bot (Jenkins) 
---
M src/cpu/x86/mtrr/mtrr.c
M src/include/cpu/x86/mtrr.h
2 files changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Elyes Haouas: Looks good to me, approved
  build bot (Jenkins): Verified

diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c
index d156d41..a3a89fe 100644
--- a/src/cpu/x86/mtrr/mtrr.c
+++ b/src/cpu/x86/mtrr/mtrr.c
@@ -346,13 +346,13 @@
    fixed_mtrrs_hide_amd_rwdram();
 }

-void x86_setup_fixed_mtrrs_no_enable(void)
+static void x86_setup_fixed_mtrrs_no_enable(void)
 {
    calc_fixed_mtrrs();
    commit_fixed_mtrrs();
 }

-void x86_setup_fixed_mtrrs(void)
+static void x86_setup_fixed_mtrrs(void)
 {
    x86_setup_fixed_mtrrs_no_enable();

diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h
index 298947a..5741afb 100644
--- a/src/include/cpu/x86/mtrr.h
+++ b/src/include/cpu/x86/mtrr.h
@@ -95,9 +95,7 @@
 void fixed_mtrrs_expose_amd_rwdram(void);
 /* Hide Rd/WrDram bits and allow modification for AMD. */
 void fixed_mtrrs_hide_amd_rwdram(void);
-void x86_setup_fixed_mtrrs(void);
-/* Set up fixed MTRRs but do not enable them. */
-void x86_setup_fixed_mtrrs_no_enable(void);
+
 void x86_mtrr_check(void);

/* Insert a temporary MTRR range for the duration of coreboot's runtime.