Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Karthik Ramasubramanian, Yu-Ping Wu.

View Change

1 comment:

• File src/soc/amd/common/vboot/vbnv_cmos.c:

  • Patch Set #4, Line 16: cmos_write(RTC_FREQ_SELECT_AMD, RTC_FREQ_SELECT);

    Is there any harm in calling cmos_init(0) just like how it is done in ramstage during every boot. […]

    are you proposing to call `cmos_init(0)` here in the platform init, or dropping the platform init and calling it universally in `vbnv_init_cmos()` instead?

To view, visit change 83495. To unsubscribe, or for help writing mail filters, visit settings.