14 comments:
Patch Set #6, Line 9: setup
The verb is spelled with a space: set up.
File src/cpu/x86/smm/smm_module_handler.c:
Patch Set #6, Line 144: * If a single processor lags then a locking/counting scheme will
Please check the coding style on how to format concise multi-line comments.
Patch Set #6, Line 195: Setup
Set up
Patch Set #6, Line 198: printk(BIOS_DEBUG, "MSEG Initialized (%d) 0x%08x 0x%08x\n",
Same debug message?
Patch Set #6, Line 211: Setup
Set up
File src/cpu/x86/smm/smm_module_loader.c:
/*
* The stub setup code assumes it is completely co
Gerrit syntax highlighting bug?
Patch Set #6, Line 179: void *fxsave_area)
Same debug message again?
Patch Set #6, Line 195: e num
Set up
Set up
/* Need a minimum stack size and alignment. */
if (params->per_cpu_stack_size <= SMM_MINIMUM_STACK_SIZE ||
(params->per_cpu_stack_size & 3) != 0)
return -1;
smm_stub_loc = NULL;
smm_stub_size = rmodule_memory_size(&smm_stub);
stub_entry_offset = rmodule_entr
Can this somehow be refactored into a separate function?
Patch Set #6, Line 274: #ifdef CONFIG_STM
Please use C code to check the Kconfig variable, if possible.
Patch Set #6, Line 277: //STM not configured - no mseg
Space after //.
File src/cpu/x86/smm/smm_stub.S:
Patch Set #6, Line 51: /* allows the STM to bring up SMM in 32-bit mode*/
Please add a space before */.
Please add a space.
To view, visit change 33235. To unsubscribe, or for help writing mail filters, visit settings.