Attention is currently required from: Krishna P Bhat D, Rizwan Qureshi, Subrata Banik.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78053?usp=email )
Change subject: soc/intel/cse: Add function to get cse_bp_info early
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/78053/comment/9100382d_fe1aa2f2 :
PS2, Line 424: store_cse_bp_info_in_cbmem
store_cse_bp_info_in_cbmem() is being called by https://review.coreboot. […]
as suggested we added a function sync_cse_bp_info_to_cbmem which add cbmem entry if not present and retrieves the entry
https://review.coreboot.org/c/coreboot/+/78053/comment/9588a878_f4d8b12d :
PS2, Line 469: cbmem_find(CBMEM_ID_CSE_BP_INFO)
cbmem_find(CBMEM_ID_CSE_BP_INFO) is used only in this case, so better not to move it to common funct […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78053?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1e72c950ba0f4911924805f501ec1bd54b6ba3c
Gerrit-Change-Number: 78053
Gerrit-PatchSet: 4
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Thu, 28 Sep 2023 18:37:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-MessageType: comment