Marked some unresolved commits as followup work.
5 comments:
File src/southbridge/amd/agesa/hudson/smbus_spd.c:
Patch Set #2, Line 133: pm_io_write8(0x2c, ioBase | 1);
pm_io_write16() ?
Ack
Patch Set #2, Line 134: __outbyte (ioBase + 0x0E, 66000000 / 400000 / 4); // set SMBus clock to 400 KHz
this is just outb() put perhaps swapped parameter order.
Ack
File src/southbridge/amd/cimx/sb800/late.c:
Patch Set #5, Line 40: #include <southbridge/amd/common/amd_pci_util.h>
missing <amdblocks/acpimmio. […]
Done
File src/southbridge/amd/pi/hudson/smbus_spd.c:
Patch Set #2, Line 134: pm_io_write8(0x2c, ioBase | 1);
pm_io_write16() perhaps?
Ack
Patch Set #2, Line 135: __outbyte (ioBase + 0x0E, 66000000 / 400000 / 4); // set SMBus clock to 400 KHz
outb()
Ack
To view, visit change 37400. To unsubscribe, or for help writing mail filters, visit settings.