Attention is currently required from: Angel Pons.
Patch set 8:Code-Review +2
View Change
1 comment:
Commit Message:
Patch Set #7, Line 9: This lock bit can be set later
This also eases unifying with Broadwell, which does the lock bit write in a dedicated finalisation function after `spi_finalize_ops()`.
That's very valueable information (i.e. we basically tested it already),
how about mentioning it in the commit message?
To view, visit change 47036. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c32127f2b4cfdfeb0e30a64e5bdda89958933cb
Gerrit-Change-Number: 47036
Gerrit-PatchSet: 8
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 18:21:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment