Attention is currently required from: Tristan Corrick, Arthur Heymans, Iru Cai (vimacs).
9 comments:
File util/autoport/azalia.go:
Patch Set #1, Line 66: RegisterPCI(0x8086, 0x0c0c, azalia{})
Mini-HD audio config is hardcoded in `nb/intel/haswell/minihd.c`. Is […]
Gone
File util/autoport/haswell.go:
This should have a space
Patch Set #22, Line 50: dq_pins_interleaved
Only matters for ULT. You can derive this from the DDR_SCRAM_MISC_CONTROL register:
const bool dq_pins_interleaved = !(MCHBAR32(0x2008) & 1 << 10)
/* FIXME:XX hardcoded. */
"c1_acpower": cstate[0],
"c2_acpower": cstate[1],
"c3_acpower": cstate[2],
"c1_battery": cstate[0],
"c2_battery": cstate[1],
"c3_battery": cstate[2],
We no longer have C-states in the devicetree for Haswell.
File util/autoport/lynxpoint.go:
PCISlot{PCIAddr: PCIAddr{Dev: 0x1c, Func: 6}, writeEmpty: true, additionalComment: "PCIe Port #7"},
PCISlot{PCIAddr: PCIAddr{Dev: 0x1c, Func: 7}, writeEmpty: true, additionalComment: "PCIe Port #8"},
We're not handling this for sandybridge
Done
Patch Set #1, Line 356: 0x0040
These values depend on the trace lengths for USB and are documented somewhere, I think
Done
File util/autoport/lynxpoint.go:
Not a problem anymore, it's determined automatically at runtime based on PCI IDs. […]
Done
/* SDIO */
RegisterPCI(0x8086, 0x9c35, GenericPCI{})
/* Smart Sound Technology Controller */
RegisterPCI(0x8086, 0x9c36, GenericPCI{})
/* Serial I/O */
for id := uint16(0x9c60); id <= 0x9c66; id++ {
RegisterPCI(0x8086, id, GenericPCI{})
}
These probably don't apply to desktops
These don't exist on non-LP.
File util/autoport/lynxpoint.go:
Patch Set #22, Line 593: gnvs := Create(ctx, "acpi_tables.c")
I would not generate this file at all.
To view, visit change 30890. To unsubscribe, or for help writing mail filters, visit settings.