Attention is currently required from: Arthur Heymans, Benjamin Doron, Felix Held, Martin L Roth.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79160?usp=email )
Change subject: Documentation: Improve x86_64 ......................................................................
Patch Set 2:
(4 comments)
File Documentation/arch/x86/x86_64.md:
https://review.coreboot.org/c/coreboot/+/79160/comment/bf0625fb_10bda864 : PS1, Line 3: experimental
Likely, it'll take time to test platforms/configurations and ensure there aren't any problems. […]
I'd prefer to make x86_64 support default in the next releases.
https://review.coreboot.org/c/coreboot/+/79160/comment/c50011ac_1038aebd : PS1, Line 24: : The large memory model causes the compiler to emit 64bit addressing : instructions, which are not only slower, but also increase code size.
Sorry, I was suggesting that the response to the question be added into the document. […]
The x86_64 code runs a bit faster, but takes longer to be fetched from SPI as the size is bigger. In the end it probably doesn't matter that much.
https://review.coreboot.org/c/coreboot/+/79160/comment/1f8bf704_68d46b2e : PS1, Line 28: must generate page tables at build time
The statement is that the toolchain *must* do this. […]
It's describing the current implementation, not a requirement.
https://review.coreboot.org/c/coreboot/+/79160/comment/bd603338_db0d7278 : PS1, Line 140: Here's a list of known issues:
I'm not sure. I'll check Intel's SDM and some AMD documentation.
It's under "KVM enabled qemu", so yes it's referring to qemu only. Real hardware is fine.