Given that we just recently revised our fast track rules after heated discussions came up around fast-tracking changes, I would have appreciated a somewhat different handling here, mostly on two points:

1. 3 CR+2 for fast track merging, this has two
2. A more detailed commit message making it clearer that this commit is about fixing a regression on master and that the change is trivial (in as many words) and how that regression came to be (a devicetree symbol was removed in cb:xxxx that duplicated devicetree behavior and that this board still used. cb:xxxx passed because ... but failed due to merge issues)

Luckily it's _really_ limited impact (a single board's device tree, targetting a symbol that was simply removed), so not much harm done, but please be more careful in the future.

View Change

To view, visit change 44300. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc6649ad693d18fdc85046ebbcc730a17fed0bf
Gerrit-Change-Number: 44300
Gerrit-PatchSet: 4
Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com>
Gerrit-Comment-Date: Sat, 08 Aug 2020 19:46:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment