Patch Set 2:

this should be across all soc then ?

Yes, it looks like this will be required for all SoCs. I am wondering if we should just move snapshot/restore to do_silicon_init() in silicon_init.c

APL/GLK is special since it calls gpio config differently than what KBL/CNL do. Hence, this issue was never seen on platforms using APL/GLK.

View Change

To view, visit change 31246. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7b6f732759538ca41c872308727b1d87c2c5d85
Gerrit-Change-Number: 31246
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:24:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment