Patch Set 54:

(2 comments)

Do some of the CamelCasedNamed files come from Tianocore? If so, some information on the commit they've been taken from would be good to have to ease future updates.

Yes - the files within security/intel/smm come directly from their Tianocore counterparts. Unnecessary code has been removed and the remaining code has been converted to meet coreboot coding requirements.

Added the gist of the previous statement to the commit

View Change

2 comments:

• File configs/config.stm:

  • Patch Set #54, Line 2:

    CONFIG_VENDOR_PURISM=y
    CONFIG_MAINBOARD_VENDOR="google"
    CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="Emulation"
    

    that's a weird combination, I guess this config underwent a couple of iterations on different boards […]

    I see the error of my ways.. I did not do a make distclean.

• File src/security/intel/stm/Kconfig:

  • Patch Set #54, Line 4: bool "Enable STM"

    The integration in mp_init. […]

    The error message (line 769) in mp_init.c has been changed to read:

        "STM not loaded because SMM is not enabled!"

    Also, added information in the Kconfig help to indicate that to have an STM, SMM must be enabled.

To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.