18 comments:
File Documentation/soc/amd/psp_integration.md:
Patch Set #3, Line 3: integration of modules into PSP tables
"structure of the PSP tables pointing to the integrated modules" maybe?
add "on the PSP"?
"on the x86 cores." maybe?
Patch Set #3, Line 19: , in order
"in the following order" at the end of the sentence?
* 0xfffa0000
* 0xfff20000
* 0xffe20000
* 0xffc20000
* 0xff820000
* 0xff020000
those are locations when the spi flash is mapped in the x86's memory space and not the locations in the flash, right? would be useful to add that information
Patch Set #3, Line 28: Most coreboot implementations
isn't that common for coreboot and not only "most", since cbfstool can put image parts at defined locations?
what does the n/nn/nnn mean here?
add a "the"?
drop "for"?
drop ","
"from reset." maybe?
Patch Set #3, Line 181: * Optional image containing a signed whitelist of serial number(s).
serial numbers?
add a ", bit 0" here to make things clearer? same for the entries below
Patch Set #3, Line 286: SubProgram
one word or space in the middle?
ABL?
i wonder how amdcompress, cbfstool and amdfwtool work together; would be good if you also describe/document that; could also be done in a follow-up patch
Patch Set #3, Line 347: it will release the x86 for execution
"the x86 starts execution when released from reset" maybe?
Patch Set #3, Line 357: passed in
"added" maybe? "passed in" sounds a bit weird to me; i'm not a native english speaker though
To view, visit change 37847. To unsubscribe, or for help writing mail filters, visit settings.