Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
src/include: Drop unneeded empty lines

Change-Id: Ie325541547ea10946f41a8f979d144a06a7e80eb
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44611
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
---
M src/include/console/flash.h
M src/include/console/spi.h
M src/include/cpu/intel/em64t100_save_state.h
M src/include/cpu/intel/em64t101_save_state.h
M src/include/cpu/intel/smm_reloc.h
M src/include/cpu/intel/speedstep.h
M src/include/cpu/x86/msr.h
M src/include/cpu/x86/mtrr.h
M src/include/cpu/x86/post_code.h
M src/include/device/dram/ddr3.h
M src/include/device/dram/ddr4.h
M src/include/device/hypertransport_def.h
M src/include/device/path.h
M src/include/device/pci_def.h
M src/include/device/pci_ids.h
M src/include/device/pci_mmio_cfg.h
M src/include/device/pnp.h
M src/include/device/resource.h
M src/include/device_tree.h
M src/include/elog.h
M src/include/input-event-codes.h
M src/include/memrange.h
M src/include/nhlt.h
M src/include/pc80/mc146818rtc.h
M src/include/reg_script.h
M src/include/smp/atomic.h
M src/include/spd.h
27 files changed, 0 insertions(+), 39 deletions(-)

diff --git a/src/include/console/flash.h b/src/include/console/flash.h
index 8104e5c..9a0dc63 100644
--- a/src/include/console/flash.h
+++ b/src/include/console/flash.h
@@ -27,5 +27,4 @@
static inline void __flashconsole_tx_flush(void) {}
#endif /* __CONSOLE_FLASH_ENABLE__ */

-
#endif /* CONSOLE_FLASH_H */
diff --git a/src/include/console/spi.h b/src/include/console/spi.h
index cb32d7e..8a58b85 100644
--- a/src/include/console/spi.h
+++ b/src/include/console/spi.h
@@ -52,6 +52,4 @@
char data[MAX_MSG_LENGTH];
} __packed;

-
-
#endif /* CONSOLE_SPI_H */
diff --git a/src/include/cpu/intel/em64t100_save_state.h b/src/include/cpu/intel/em64t100_save_state.h
index 8596ce5..b656a28 100644
--- a/src/include/cpu/intel/em64t100_save_state.h
+++ b/src/include/cpu/intel/em64t100_save_state.h
@@ -66,7 +66,6 @@
u64 rsi;
u64 rdi;

-
u64 io_mem_addr;
u32 io_misc_info;

diff --git a/src/include/cpu/intel/em64t101_save_state.h b/src/include/cpu/intel/em64t101_save_state.h
index 2e4e0d5..6884b28 100644
--- a/src/include/cpu/intel/em64t101_save_state.h
+++ b/src/include/cpu/intel/em64t101_save_state.h
@@ -6,7 +6,6 @@
#include <types.h>
#include <cpu/x86/smm.h>

-
/* Intel Revision 30101 SMM State-Save Area
* The following processor architectures use this:
* - Westmere
@@ -83,7 +82,6 @@
u64 rsi;
u64 rdi;

-
u64 io_mem_addr;
u32 io_misc_info;

diff --git a/src/include/cpu/intel/smm_reloc.h b/src/include/cpu/intel/smm_reloc.h
index 07fe038..126aa2a 100644
--- a/src/include/cpu/intel/smm_reloc.h
+++ b/src/include/cpu/intel/smm_reloc.h
@@ -51,7 +51,6 @@

bool cpu_has_alternative_smrr(void);

-
#define MSR_PRMRR_PHYS_BASE 0x1f4
#define MSR_PRMRR_PHYS_MASK 0x1f5
#define MSR_UNCORE_PRMRR_PHYS_BASE 0x2f4
diff --git a/src/include/cpu/intel/speedstep.h b/src/include/cpu/intel/speedstep.h
index d66b8e2..e085e34 100644
--- a/src/include/cpu/intel/speedstep.h
+++ b/src/include/cpu/intel/speedstep.h
@@ -18,7 +18,6 @@
*/
#define PMB1_BASE 0x800

-
/* Speedstep related MSRs */
#define MSR_THERM2_CTL 0x19D
#define MSR_EBC_FREQUENCY_ID 0x2c
diff --git a/src/include/cpu/x86/msr.h b/src/include/cpu/x86/msr.h
index 1573eef..3deb133 100644
--- a/src/include/cpu/x86/msr.h
+++ b/src/include/cpu/x86/msr.h
@@ -299,7 +299,6 @@
return MCA_ERRTYPE_UNKNOWN;
}

-
/* Helper for setting single MSR bits */
static inline void msr_set_bit(unsigned int reg, unsigned int bit)
{
@@ -318,6 +317,5 @@
wrmsr(reg, msr);
}

-
#endif /* __ASSEMBLER__ */
#endif /* CPU_X86_MSR_H */
diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h
index 6e30199..3bf8301c 100644
--- a/src/include/cpu/x86/mtrr.h
+++ b/src/include/cpu/x86/mtrr.h
@@ -27,7 +27,6 @@
#define MTRR_DEF_TYPE_EN (1 << 11)
#define MTRR_DEF_TYPE_FIX_EN (1 << 10)

-
#define IA32_SMRR_PHYS_BASE 0x1f2
#define IA32_SMRR_PHYS_MASK 0x1f3
#define SMRR_PHYS_MASK_LOCK (1 << 10)
diff --git a/src/include/cpu/x86/post_code.h b/src/include/cpu/x86/post_code.h
index fce39b7..077f964 100644
--- a/src/include/cpu/x86/post_code.h
+++ b/src/include/cpu/x86/post_code.h
@@ -3,7 +3,6 @@

#include <console/post_codes.h>

-
#if CONFIG(POST_IO)
#define post_code(value) \
movb $value, %al; \
diff --git a/src/include/device/dram/ddr3.h b/src/include/device/dram/ddr3.h
index 74e0ff55..0814990 100644
--- a/src/include/device/dram/ddr3.h
+++ b/src/include/device/dram/ddr3.h
@@ -19,7 +19,6 @@
#include <device/dram/common.h>
#include <types.h>

-
/**
* Convenience definitions for SPD offsets
*
diff --git a/src/include/device/dram/ddr4.h b/src/include/device/dram/ddr4.h
index f258fa9..d22d4bc 100644
--- a/src/include/device/dram/ddr4.h
+++ b/src/include/device/dram/ddr4.h
@@ -21,7 +21,6 @@
#define SPD_DDR4_PART_OFF 329
#define SPD_DDR4_PART_LEN 20

-
/*
* Module type (byte 3, bits 3:0) of SPD
* This definition is specific to DDR4. DDR2/3 SPDs have a different structure.
diff --git a/src/include/device/hypertransport_def.h b/src/include/device/hypertransport_def.h
index a0b1a36..3cbd90b 100644
--- a/src/include/device/hypertransport_def.h
+++ b/src/include/device/hypertransport_def.h
@@ -18,7 +18,6 @@
#define HT_FREQ_2600Mhz 14
#define HT_FREQ_VENDOR 15 /* AMD defines this to be 100Mhz */

-
static inline bool offset_unit_id(bool is_sb_ht_chain)
{
bool need_offset = (CONFIG_HT_CHAIN_UNITID_BASE != 1)
diff --git a/src/include/device/path.h b/src/include/device/path.h
index 4db83b7..5690bad 100644
--- a/src/include/device/path.h
+++ b/src/include/device/path.h
@@ -137,7 +137,6 @@
};
};

-
#define DEVICE_PATH_MAX 40
#define BUS_PATH_MAX (DEVICE_PATH_MAX+10)

diff --git a/src/include/device/pci_def.h b/src/include/device/pci_def.h
index 25372bf..e0d891e 100644
--- a/src/include/device/pci_def.h
+++ b/src/include/device/pci_def.h
@@ -305,7 +305,6 @@
#define PCI_MSIX_PBA_OFFSET ~0x7 /* Offset into specified BAR */
#define PCI_CAP_MSIX_SIZEOF 12 /* size of MSIX registers */

-
/* CompactPCI Hotswap Register */

#define PCI_CHSWP_CSR 2 /* Control and Status Register */
@@ -521,7 +520,6 @@
#define PCI_PWR_CAP 12 /* Capability */
#define PCI_PWR_CAP_BUDGET(x) ((x) & 1) /* Included in system budget */

-
/*
* The PCI interface treats multi-function devices as independent
* devices. The slot/function address of each device is encoded
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index cbb1975..944c20e 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -517,7 +517,6 @@
#define PCI_DEVICE_ID_NS_SCx200_XBUS 0x0505
#define PCI_DEVICE_ID_NS_87410 0xd001

-
#define PCI_VENDOR_ID_TSENG 0x100c
#define PCI_DEVICE_ID_TSENG_W32P_2 0x3202
#define PCI_DEVICE_ID_TSENG_W32P_b 0x3205
@@ -1664,7 +1663,6 @@
#define PCI_DEVICE_ID_ATT_L56XMF 0x0440
#define PCI_DEVICE_ID_ATT_VENUS_MODEM 0x480

-
#define PCI_VENDOR_ID_SPECIALIX 0x11cb
#define PCI_DEVICE_ID_SPECIALIX_IO8 0x2000
#define PCI_DEVICE_ID_SPECIALIX_XIO 0x4000
diff --git a/src/include/device/pci_mmio_cfg.h b/src/include/device/pci_mmio_cfg.h
index d3666c2..234ebb4 100644
--- a/src/include/device/pci_mmio_cfg.h
+++ b/src/include/device/pci_mmio_cfg.h
@@ -7,7 +7,6 @@
#include <device/mmio.h>
#include <device/pci_type.h>

-
/* By not assigning this to CONFIG_MMCONF_BASE_ADDRESS here we
* prevent some sub-optimal constant folding. */
extern u8 *const pci_mmconf;
diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h
index 800bcc0..7340bbf 100644
--- a/src/include/device/pnp.h
+++ b/src/include/device/pnp.h
@@ -67,7 +67,6 @@
void pnp_enable_devices(struct device *dev, struct device_operations *ops,
unsigned int functions, struct pnp_info *info);

-
struct pnp_mode_ops {
void (*enter_conf_mode)(struct device *dev);
void (*exit_conf_mode)(struct device *dev);
diff --git a/src/include/device/resource.h b/src/include/device/resource.h
index 42c7e6a..3a7ccf0 100644
--- a/src/include/device/resource.h
+++ b/src/include/device/resource.h
@@ -109,7 +109,6 @@
const struct device *largest_resource(struct bus *bus, struct resource **result_res,
unsigned long type_mask, unsigned long type);

-
/* Compute and allocate resources. This is the main resource allocator entry point. */
void allocate_resources(const struct device *root);

diff --git a/src/include/device_tree.h b/src/include/device_tree.h
index b70f5aa..ae30c59 100644
--- a/src/include/device_tree.h
+++ b/src/include/device_tree.h
@@ -43,8 +43,6 @@
uint32_t size;
};

-
-
/*
* Unflattened device tree structures.
*/
@@ -88,8 +86,6 @@
struct device_tree_node *root;
};

-
-
/*
* Flattened device tree functions. These generally return the number of bytes
* which were consumed reading the requested value.
@@ -109,8 +105,6 @@
invalidates the unflattened one. */
struct device_tree *fdt_unflatten(const void *blob);

-
-
/*
* Unflattened device tree functions.
*/
diff --git a/src/include/elog.h b/src/include/elog.h
index c41887a..8c50e00 100644
--- a/src/include/elog.h
+++ b/src/include/elog.h
@@ -202,7 +202,6 @@
#define ELOG_TYPE_MI_HRPC 0xb4
#define ELOG_TYPE_MI_HR 0xb5

-
struct elog_event_extended_event {
u8 event_type;
u32 event_complement;
diff --git a/src/include/input-event-codes.h b/src/include/input-event-codes.h
index 006c262..abb1e08 100644
--- a/src/include/input-event-codes.h
+++ b/src/include/input-event-codes.h
@@ -870,7 +870,6 @@
#define ABS_MT_TOOL_X 0x3c /* Center X tool position */
#define ABS_MT_TOOL_Y 0x3d /* Center Y tool position */

-
#define ABS_MAX 0x3f
#define ABS_CNT (ABS_MAX+1)

diff --git a/src/include/memrange.h b/src/include/memrange.h
index 72cfa72..80db598 100644
--- a/src/include/memrange.h
+++ b/src/include/memrange.h
@@ -82,7 +82,6 @@
#define memranges_each_entry(r, ranges) \
for (r = (ranges)->entries; r != NULL; r = r->next)

-
/* Initialize memranges structure providing an optional array of range_entry
* to use as the free list. Additionally, it accepts an align parameter that
* represents the required alignment(log 2) of addresses. */
diff --git a/src/include/nhlt.h b/src/include/nhlt.h
index 30cb274..3355801 100644
--- a/src/include/nhlt.h
+++ b/src/include/nhlt.h
@@ -219,7 +219,6 @@
SPEAKER_TOP_BACK_RIGHT = 1 << 17,
};

-
/* Supporting structures. Only SoC/chipset and the library code directly should
* be manipulating these structures. */
struct sub_format {
diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h
index a2c65cb..2f94cc0 100644
--- a/src/include/pc80/mc146818rtc.h
+++ b/src/include/pc80/mc146818rtc.h
@@ -17,7 +17,6 @@
#define RTC_REG_C 12
#define RTC_REG_D 13

-
/**********************************************************************
* register details
**********************************************************************/
diff --git a/src/include/reg_script.h b/src/include/reg_script.h
index 59da0cb..aa6bf80 100644
--- a/src/include/reg_script.h
+++ b/src/include/reg_script.h
@@ -355,7 +355,6 @@
#define REG_RES_XOR32(bar_, reg_, value_) \
REG_RES_RXW32(bar_, reg_, 0xffffffff, value_)

-
#if CONFIG(SOC_INTEL_BAYTRAIL)
/*
* IO Sideband Function
diff --git a/src/include/smp/atomic.h b/src/include/smp/atomic.h
index ed70cb7..5e78ae4 100644
--- a/src/include/smp/atomic.h
+++ b/src/include/smp/atomic.h
@@ -31,7 +31,6 @@
*/
#define atomic_set(v, i) (((v)->counter) = (i))

-
/**
* atomic_inc - increment atomic variable
* @param v: pointer of type atomic_t
@@ -41,7 +40,6 @@
*/
#define atomic_inc(v) (((v)->counter)++)

-
/**
* atomic_dec - decrement atomic variable
* @param v: pointer of type atomic_t
@@ -51,7 +49,6 @@
*/
#define atomic_dec(v) (((v)->counter)--)

-
#endif /* CONFIG_SMP */

#endif /* SMP_ATOMIC_H */
diff --git a/src/include/spd.h b/src/include/spd.h
index f46bde6..9afb706 100644
--- a/src/include/spd.h
+++ b/src/include/spd.h
@@ -136,7 +136,6 @@
/* SDRAM Device Minimum Auto Refresh to Active/Auto Refresh (tRFC) */
#define SPD_tRFC 42

-
/* SPD_MEMORY_TYPE values. */
enum spd_memory_type {
SPD_MEMORY_TYPE_UNDEFINED = 0x00,

To view, visit change 44611. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie325541547ea10946f41a8f979d144a06a7e80eb
Gerrit-Change-Number: 44611
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged