Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Julius Werner would like Furquan Shaikh and Tim Wawrzynczak to review this change.
coreboot_tables: Print strapping IDs when adding them to coreboot table
These used to be printed before CB:46605. Having them in the logs can be
a huge timesaver when debugging logs sent to you by other people
(especially from systems that don't boot all the way). Let's add them
back.
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: Ifdbfdd29d25a0937c27113ace776f7aec231a57d
---
M src/lib/coreboot_table.c
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/52011/1
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index 29be857..1d23b33 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -305,10 +305,20 @@
config->tag = LB_TAG_BOARD_CONFIG;
config->size = sizeof(*config);
+ uint64_t fw_config = fw_config_get();
config->board_id = board_id();
config->ram_code = ram_code();
config->sku_id = sku_id();
- config->fw_config = pack_lb64(fw_config_get());
+ config->fw_config = pack_lb64(fw_config);
+
+ if (config->board_id != UNDEFINED_STRAPPING_ID)
+ printk(BIOS_INFO, "Board ID: %d\n", config->board_id);
+ if (config->ram_code != UNDEFINED_STRAPPING_ID)
+ printk(BIOS_INFO, "RAM code: %d\n", config->ram_code);
+ if (config->sku_id != UNDEFINED_STRAPPING_ID)
+ printk(BIOS_INFO, "SKU ID: %d\n", config->sku_id);
+ if (fw_config != UNDEFINED_FW_CONFIG)
+ printk(BIOS_INFO, "FW config: %#llx\n", fw_config);
return config;
}
To view, visit change 52011. To unsubscribe, or for help writing mail filters, visit settings.