Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49187 )
Change subject: soc/intel/jasperlake: Update acoustic noise related parameters
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49187/1/src/soc/intel/jasperlake/fs...
File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49187/1/src/soc/intel/jasperlake/fs...
PS1, Line 240:
Check for superfluous whitespace in the tree (lint-stable-003-whitespace): File src/soc/intel/jasper […]
Done
https://review.coreboot.org/c/coreboot/+/49187/1/src/soc/intel/jasperlake/fs...
PS1, Line 244: 0
For which VR domain is this? Why is the assumption here that the mainboard setting is for VR domain- […]
Hi Furquan,
Jasperlake only supports VR domain 0 and it doesn't have multiple VR domains as in TGL.
That is the reason we only set it for VR domain 0.
Reference: JSL EDS vol1 (Document# 613601, chapter 3.4.1)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0cf4ccfced13b0d32b3d20713eace63e66945332
Gerrit-Change-Number: 49187
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 Jan 2021 06:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment