Naveen M has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32474 )
Change subject: mb/google/hatch: Modify IRQ configuration to enable RT5682 headset INT ......................................................................
Patch Set 3:
(2 comments)
Thanks
https://review.coreboot.org/#/c/32474/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32474/2//COMMIT_MSG@9 PS2, Line 9: Patch corrects IRQ and GPIO configuration for RT5682 codec's Jack INT
It would be good to add some context saying why it was changed from IOAPIC to GPIO INT.
Done
https://review.coreboot.org/#/c/32474/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32474/2/src/mainboard/google/hatch/variants/... PS2, Line 349: TODO Configure it back to invert mode, when : * ITSS IPCx configuration is fixed in FSP.
Can get rid of this comment now. It no longer holds.
Ack