3 comments:
Patch Set #6, Line 11: exit boot service
What is that in coreboot terms?
It would be equivalent to coreboot's END_OF_FIRMWARE boot state.
File src/soc/intel/tigerlake/chip.c:
Patch Set #6, Line 119: , uint16_t device_id
Hm unless this was a check to see if the device isn't disabled? if so can you add a comment?
coreboot will be updated to check both dev and its device ID match before invoking the above pci_dev_disable_bus_master().
Patch Set #6, Line 134: platform_fsp_notify_status
Why is it implemted here? Does FSP require BME to be cleared?
FSP is typically driven by coreboot. END_OF_FIRMWARE is a later boot stage where it is proper to disable bus master.
To view, visit change 40968. To unsubscribe, or for help writing mail filters, visit settings.