View Change

15 comments:

• Commit Message:

  • Patch Set #1, Line 9: Yanling YL-KBR6L

    Do you have an URL for that? (I know, some folks do not like URLs in commit messages.)

  • Patch Set #1, Line 15: SeaBIOS, Linux and FreeBSD

    For the record, can you please also note down the used version of these?

  • Patch Set #1, Line 17: VGA Option ROM

    Extracted how?

  • Patch Set #1, Line 18: flashrom

    What version?

  • Patch Set #1, Line 25: Crucial CT2K32G4SFD8266

    Is that one DIMM with 64 GB?

  • Patch Set #1, Line 32: Removed

    Present tense: Remove

• File Documentation/mainboard/yanling/yl-kbr6l.md:

  • Patch Set #1, Line 3: Protectli FW6

    Please link to the page.

  • Patch Set #1, Line 33:

    VGA Option ROM is not required to boot, but if one needs graphics in pre-OS
    stage, it should be included (if not using libgfxinit).
    

    Maybe:

    Graphics initialization is not required in firmware for graphics in the OS. But for graphics in pre-OS stage (payload), libgfxinit or the VGA Option ROM are required.

    Is the GOP driver also supported (by FSP)?

  • Patch Set #1, Line 40: The main SPI flash can be accessed using [flashrom].

    Maybe clarify, that this also applies to the vendor firmware.

  • Patch Set #1, Line 56: - assume the same as for Protectli FW6:

    Remove the “bullet point”?

  • Patch Set #1, Line 63: return

    returns

  • Patch Set #1, Line 64:

    or
      temporarily disconnect
    

    or *to* temporarily disconnect

  • Patch Set #1, Line 66: dim

    What does that mean?

  • Patch Set #1, Line 70: - assume the same as for Protectli FW6:

    Remove the “bullet point”?

  • Patch Set #1, Line 133: [Yanling N18]:https://www.ylipc.com/product/network_server_network_server/N18_Firewall_Mini_PC.html

    Please add a space after the colon.

To view, visit change 48769. To unsubscribe, or for help writing mail filters, visit settings.