View Change

2 comments:

• File src/soc/intel/tigerlake/fsp_params.c:

  • Patch Set #1, Line 135: TGL_LP_GPIO_ID

    Can you please add a comment why this is required to be set even if there is no bias_control information being provided?

• File src/soc/intel/tigerlake/include/soc/early_tcss.h:

  • Patch Set #1, Line 102: TGL_LP_GPIO_ID

    Can you please add a comment here that this is expected to be set by FSP and it represents the GPIO chipset ID for LP.

    (This is another example of how FSP is leaking its assumptions into external components).

To view, visit change 47860. To unsubscribe, or for help writing mail filters, visit settings.