Subrata Banik submitted this change.

View Change

Approvals: build bot (Jenkins): Verified V Sowmya: Looks good to me, approved
mb/intel/adlrvp: Update GPIO configuration as per schematics

Configure I2C related GPIO as per ADL-P schematics.
This is based on Revision 0.974 of schematics.

Signed-off-by: Varshit Pandya <varshit.b.pandya@intel.com>
Change-Id: I76e1207cb31bed10b6e9fbeb2456b6feec42f97e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47495
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: V Sowmya <v.sowmya@intel.com>
---
M src/mainboard/intel/adlrvp/gpio.c
1 file changed, 12 insertions(+), 32 deletions(-)

diff --git a/src/mainboard/intel/adlrvp/gpio.c b/src/mainboard/intel/adlrvp/gpio.c
index 4cb8c3a..9b94cec 100644
--- a/src/mainboard/intel/adlrvp/gpio.c
+++ b/src/mainboard/intel/adlrvp/gpio.c
@@ -138,22 +138,16 @@
/* SPI_MOSI(2) */
PAD_CFG_NF(GPP_D12, NONE, DEEP, NF2),

- /* SPI_MIS0(0) */
- PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1),
/* SPI_MIS0(1) */
PAD_CFG_NF(GPP_B21, NONE, DEEP, NF1),
/* SPI_MIS0(2) */
PAD_CFG_NF(GPP_D11, NONE, DEEP, NF2),

- /* SPI_CLK(0) */
- PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1),
/* SPI_CLK(1) */
PAD_CFG_NF(GPP_B20, NONE, DEEP, NF1),
/* SPI_CLK(2) */
PAD_CFG_NF(GPP_D10, NONE, DEEP, NF2),

- /* SPI_CS(0, 0) */
- PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1),
/* SPI_CS(0, 1) */
PAD_CFG_NF(GPP_B14, NONE, DEEP, NF1),
/* SPI_CS(1, 0) */
@@ -162,34 +156,26 @@
PAD_CFG_NF(GPP_D9, NONE, DEEP, NF2),

/* I2C_SCL(0) */
- PAD_CFG_NF(GPP_C17, NONE, DEEP, NF1),
- /* I2C_SCL(1) */
- PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1),
- /* I2C_SCL(2) */
PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1),
- /* I2C_SCL(3) */
+ /* I2C_SCL(1) */
PAD_CFG_NF(GPP_H7, NONE, DEEP, NF1),
+ /* I2C_SCL(2) */
+ PAD_CFG_NF(GPP_B6, NONE, DEEP, NF2),
+ /* I2C_SCL(3) */
+ PAD_CFG_NF(GPP_B8, NONE, DEEP, NF2),
/* I2C_SCL(5) */
- PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1),
- /* I2C_SCL(6) */
- PAD_CFG_NF(GPP_T1, NONE, DEEP, NF1),
- /* I2C_SCL(7) */
- PAD_CFG_NF(GPP_T3, NONE, DEEP, NF1),
+ PAD_CFG_NF(GPP_B17, NONE, DEEP, NF2),

/* I2C_SDA(0) */
- PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1),
- /* I2C_SDA(1) */
- PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1),
- /* I2C_SDA(2) */
PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1),
- /* I2C_SDA(3) */
+ /* I2C_SDA(1) */
PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1),
+ /* I2C_SDA(2) */
+ PAD_CFG_NF(GPP_B5, NONE, DEEP, NF2),
+ /* I2C_SDA(3) */
+ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF2),
/* I2C_SDA(5) */
- PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1),
- /* I2C_SDA(6) */
- PAD_CFG_NF(GPP_T0, NONE, DEEP, NF1),
- /* I2C_SDA(7) */
- PAD_CFG_NF(GPP_T2, NONE, DEEP, NF1),
+ PAD_CFG_NF(GPP_B16, NONE, DEEP, NF2),

/* I2S0_SCLK */
PAD_CFG_NF(GPP_R0, NONE, DEEP, NF2),
@@ -255,10 +241,6 @@

/* USB2 OC0 pins */
PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),
- /* USB2 OC1 pins */
- PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1),
- /* USB2 OC2 pins */
- PAD_CFG_NF(GPP_A15, NONE, DEEP, NF1),
/* USB2 OC3 pins */
PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1),

@@ -267,8 +249,6 @@
PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1),
PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1),
PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1),
- PAD_CFG_NF(GPP_H10, NONE, DEEP, NF1),
- PAD_CFG_NF(GPP_H11, NONE, DEEP, NF1),
PAD_CFG_NF(GPP_H19, NONE, DEEP, NF1),
PAD_CFG_NF(GPP_F19, NONE, DEEP, NF1),


To view, visit change 47495. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76e1207cb31bed10b6e9fbeb2456b6feec42f97e
Gerrit-Change-Number: 47495
Gerrit-PatchSet: 6
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged