Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Leon Groß, Nico Huber, Patrick Rudolph, Paul Menzel.
View Change
1 comment:
Patchset:
Patch Set #4:
I don't see any benefit of having support for SIMICS default QSP target as it's emulating even less bits than QEMU.
So this simulated target does not simulate a lot of hardware so this indeed is mostly a stub. So from the perspective of testing more stuff, it's not an added value. When SIMICS is used with another more real target, there is no use for this code.
I was told that Intel uses this QSP target (internally) in SIMICS training, so mostly to people get familiar with both firmware building and testing it on this simulator. I think this use case is what makes this target a valuable addition to coreboot.
To view, visit change 77905. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I175b20bb4746608e4d868aa96492fc06c149bd36
Gerrit-Change-Number: 77905
Gerrit-PatchSet: 16
Gerrit-Owner: Leon Groß <leon.gross@9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Leon Groß <leon.gross@9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Comment-Date: Thu, 25 Jan 2024 16:33:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com>
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00@gmail.com>
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-MessageType: comment