View Change

5 comments:

• File src/soc/amd/stoneyridge/Kconfig:

  • Patch Set #3, Line 25:

    
    ## Merlinfalcon only supports FP4.
    

    Meh, I could do without this comment. […]

    Ok.

  • Patch Set #3, Line 32: config SOC_AMD_PSP_SELECTABLE_SMU_FW

    Move this item to below CPU_SPECIFIC_OPTIONS somewhere. […]

    Will do.

  • Patch Set #3, Line 37:

      Some PSP implementations allow storing SMU firmware into cbfs and
    	  calling the PSP to load the blobs at the proper time.
    
    	  The soc/<codename> should select this if its PSP supports the feature
    	  and each mainboard can choose to select an appropriate fanless or
    	  fanned set of blobs.  Ask your AMD representative whether your APU
    	  is considered fanless.
    

    You're free to override the default help text with anything you want. […]

    Thanks, will do.

• File src/soc/amd/stoneyridge/Makefile.inc:

  • Patch Set #3, Line 204: endif

    This starts to get confusing. […]

    I tried, unfortunately no. It would require dummy *_FN images, otherwise build fails.

  • Patch Set #3, Line 225: ifeq ($(CONFIG_SOC_AMD_PSP_SELECTABLE_SMU_FW),y)

    You probably won't need this. […]

    Will try.

To view, visit change 33621. To unsubscribe, or for help writing mail filters, visit settings.