Patch Set 91:
What's the maximum file size?

There's no strict limit, just keep in mind that these files will remain in coreboot's git history forever (long after the board is dead, the code removed and the documentation pruned), so as small as is reasonable for the content?

Try different compression values and see what configuration is the smallest that still provides a visually pleasing representation (ie. not blocky pixel soup).

I played around a bit: top.jpg can be compressed better (fewer sharp edges because there's no text), and at q50 I get a reasonable looking image at 29K. bottom.jpg requires a bit more and looks good to me at q70, which brings it to 45K. At q50 (33K) the "pass" sticker looks slightly odd - but if you think that's good enough, by all means go down to that level :-)

View Change

To view, visit change 31378. To unsubscribe, or for help writing mail filters, visit settings.