Martin Roth merged this change.

View Change

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
soc/amd/stoneyridge: Add ALink-AHB Bridge to iomap.h

Add the address and replace the hardcoded value in the ASL code.

Change-Id: If0b99de78d8c5948e2e5f2aa50dfc2efc1bd1ba1
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32662
Reviewed-by: Martin Roth <martinroth@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/soc/amd/stoneyridge/acpi/sb_fch.asl
M src/soc/amd/stoneyridge/include/soc/iomap.h
2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/soc/amd/stoneyridge/acpi/sb_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_fch.asl
index 4c1196d..e7975f8 100644
--- a/src/soc/amd/stoneyridge/acpi/sb_fch.asl
+++ b/src/soc/amd/stoneyridge/acpi/sb_fch.asl
@@ -22,7 +22,7 @@
Name (_UID, 0x0)
Name (_CRS, ResourceTemplate()
{
- Memory32Fixed (ReadWrite, 0xFEDC0000, 0x2000)
+ Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
})

Method (_STA, 0x0, NotSerialized)
diff --git a/src/soc/amd/stoneyridge/include/soc/iomap.h b/src/soc/amd/stoneyridge/include/soc/iomap.h
index 1caef33..3856a22 100644
--- a/src/soc/amd/stoneyridge/include/soc/iomap.h
+++ b/src/soc/amd/stoneyridge/include/soc/iomap.h
@@ -25,6 +25,8 @@
/* AcpiMmio blocks are at fixed offsets from FED8_0000h, enabled in PMx04[1] */
#include <amdblocks/acpimmio_map.h>

+#define ALINK_AHB_ADDRESS 0xfedc0000
+
/* I2C fixed address */
#define I2C_BASE_ADDRESS 0xfedc2000
#define I2C_DEVICE_SIZE 0x00001000

To view, visit change 32662. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0b99de78d8c5948e2e5f2aa50dfc2efc1bd1ba1
Gerrit-Change-Number: 32662
Gerrit-PatchSet: 7
Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged