15 comments:
File Documentation/drivers/smmstorev2.md:
Patch Set #14, Line 17: unformated
unformatted
Done
used,
Done
Patch Set #14, Line 68: assuptions
assumptions
Done
in
Done
Patch Set #14, Line 123: to write
writing
reading, but done
Patch Set #14, Line 124: meanful
meaningful
Done
Patch Set #14, Line 144: to write
writing
Done
Patch Set #14, Line 165: to clear
clearing
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
Patch Set #14, Line 82: LB_TAG_SMMSTOREV2 = 0x0038,
this will need to be adjusted via a rebase, since LB_TAG_PLATFORM_BLOB_VERSION is now 0x038
Done
File src/drivers/smmstore/smi.c:
Patch Set #14, Line 144: param
the eventual range_check() seems like it will implicitly catch null pointers, but it might be cleare […]
Done
File src/drivers/smmstore/store.c:
APM
Done
Patch Set #14, Line 416: if (offset >= region_device_sz(&com_buf)) {
nit: blank line after if
Done
Patch Set #14, Line 425: ptr = rdev_mmap(&com_buf, offset, bufsize);
nit: blank line after if
Done
Patch Set #14, Line 430: ret = rdev_writeat(&store, ptr, 0, bufsize);
nit: blank line after if
Done
Patch Set #14, Line 450: // NOTE: Not really necessarry..
I think it's okay to be a little extra paranoid in SMM. […]
I added this check to all four functions.
To view, visit change 40520. To unsubscribe, or for help writing mail filters, visit settings.