Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35799/5/src/soc/intel/common/block/... File src/soc/intel/common/block/sgx/sgx.c:
https://review.coreboot.org/c/coreboot/+/35799/5/src/soc/intel/common/block/... PS5, Line 213: CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_ENABLE)
check now on invocation instead
Done
https://review.coreboot.org/c/coreboot/+/35799/12/src/soc/intel/icelake/chip... File src/soc/intel/icelake/chip.h:
https://review.coreboot.org/c/coreboot/+/35799/12/src/soc/intel/icelake/chip... PS12, Line 278: get_prmrr_size
This is not a good place for function declaration
If you know a better place, tell me, please. I wasn't sure where this is put best :)
https://review.coreboot.org/c/coreboot/+/35799/12/src/soc/intel/icelake/memm... File src/soc/intel/icelake/memmap.c:
https://review.coreboot.org/c/coreboot/+/35799/12/src/soc/intel/icelake/memm... PS12, Line 51: get_prmrr_size
I'd use a common definition. […]
Done