Michael Büchler has uploaded this change for review.
board_status/getrevision.sh: Ignore non-annotated tags
Local tags (e.g. to keep track of builds) should not be used to describe
a board status report. This has happened in some cases, e.g. [1].
According to the Git 2.41.0 manual for git-describe, the '--tagged'
parameter is a way to also use any "lightweight (non-annotated) tag" in
addition to annotated tags, which are always used even without this
parameter. All coreboot release tags seem to be annotated, so this
option should be safe to drop.
[1] https://review.coreboot.org/plugins/gitiles/board-status/+/b8c47429bad5afc5cd7f798cad3dece9790a1f83
Signed-off-by: Michael Büchler <michael.buechler@posteo.net>
Change-Id: I54b302415e569a3385559cc85323ce34462042ad
---
M util/board_status/getrevision.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/79837/1
diff --git a/util/board_status/getrevision.sh b/util/board_status/getrevision.sh
index ced20fc..a982f8d 100755
--- a/util/board_status/getrevision.sh
+++ b/util/board_status/getrevision.sh
@@ -112,7 +112,7 @@
local r
if git_is_file_tracked "$1" ; then
- r=$(git describe --tags --dirty)
+ r=$(git describe --dirty)
else
return ${EXIT_FAILURE}
fi
To view, visit change 79837. To unsubscribe, or for help writing mail filters, visit settings.