[coreboot-gerrit] [S] Change in coreboot[master]: security/intel/txt: Add helper function to disable TXT

[Subrata Banik (Code Review)]

Attention is currently required from: Jérémy Compostella, Paul Menzel, Sridhar Siricilla, Angel Pons, Lean Sheng Tan, Werner Zeh.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71574 )

Change subject: security/intel/txt: Add helper function to disable TXT
......................................................................

Patch Set 6:

(1 comment)

File src/security/intel/txt/txtlib.c:

https://review.coreboot.org/c/coreboot/+/71574/comment/2f18ecb2_00a75f7e 
PS5, Line 63: 		printk(BIOS_INFO, "CPU is not TXT capable.\n");
> Thank you for sharing the logs, helping me. If we know in the beginning already, if TXT is supported or not, can the caller also only call the function, if TXT is supported?

if your concern is to reuse the API rather than implementing it here, please refer to the code: https://github.com/coreboot/coreboot/blob/master/src/soc/intel/alderlake/boo.... The code inside bootblock that checks for TXT and other CPU support flag is not an function actually. Otherwise I would have use it.
> Otherwise that information would also be logged twice.

if your concern is logging it twice, as I suggested, we can drop that additional print. Please let me know.