Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30218 )
Change subject: vendorcode/eltan: Add vendor code for measured and verified boot. ......................................................................
Patch Set 7:
(7 comments)
https://review.coreboot.org/#/c/30218/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30218/7//COMMIT_MSG@7 PS7, Line 7: vendorcode/eltan: Add vendor code for measured and verified boot. Please, no full stops at the end of the commit summary.
https://review.coreboot.org/#/c/30218/7//COMMIT_MSG@14 PS7, Line 14: Kconfg Kconf*i*g
https://review.coreboot.org/#/c/30218/7/Documentation/vendorcode/eltan/secur... File Documentation/vendorcode/eltan/security.md:
https://review.coreboot.org/#/c/30218/7/Documentation/vendorcode/eltan/secur... PS7, Line 5: Verify "Verified" ?
https://review.coreboot.org/#/c/30218/7/Documentation/vendorcode/eltan/secur... PS7, Line 6: used only small library for the encryption leave as much more space in flash : available for payload uses a smaller encryption library and leaves much more space in flash for the payload.
https://review.coreboot.org/#/c/30218/7/Documentation/vendorcode/eltan/secur... PS7, Line 10: sha1, sha256 and sha512 SHA-1, SHA-256 and SHA-512
https://review.coreboot.org/#/c/30218/7/Documentation/vendorcode/eltan/secur... PS7, Line 11: Please, no trailing whitespace.
https://review.coreboot.org/#/c/30218/7/Documentation/vendorcode/eltan/secur... PS7, Line 18: trailing whitespace