Attention is currently required from: Felix Singer, Jack Rosenthal, Nikolai Artemiev.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59714 )
Change subject: util/cbfstool: Port elogtool to libflashrom
......................................................................
Patch Set 7:
(2 comments)
File util/cbfstool/uflashrom.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137325):
https://review.coreboot.org/c/coreboot/+/59714/comment/e30634b9_1df2c438
PS7, Line 33: unsigned offset = 0;
Prefer 'unsigned int' to bare use of 'unsigned'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137325):
https://review.coreboot.org/c/coreboot/+/59714/comment/47a033a0_2b777e2f
PS7, Line 91: * at the offset from the set layout rather than at the begining of the
'begining' may be misspelled - perhaps 'beginning'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59714
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79df2934b9b0492a554a4fecdd533a0abe1df231
Gerrit-Change-Number: 59714
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 07:56:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment