I think the patch train probably needs to be rebased on
11 comments:
Patch Set #47, Line 9: Internal Cleanup:
shouldn't this be just "b:"?
Patch Set #47, Line 10: mandolin
Nit: Maybe change to "Build & boot on mandolin"
File src/soc/amd/picasso/Makefile.inc:
Patch Set #47, Line 125: "3rdparty/amd_blobs/picasso/PSP"
I mention this in the other locations as well. Could this be moved back into a Kconfig symbol so it can be updated by a platform if desired?
File src/soc/amd/picasso/fw.cfg:
Patch Set #47, Line 3: # Should be first line
Why does the location need to be the first line? Doesn't the parser look through the entire file for this?
File src/soc/amd/stoneyridge/Makefile.inc:
Patch Set #47, Line 105: ifeq ($(CONFIG_AMD_APU_STONEYRIDGE),y)
Can we put the directory values into a Kconfig option instead of hardcoding them into the makefile?
Patch Set #47, Line 106: FIRMWARE_LOCATE
Change to FIRMWARE_LOCATION?
File src/southbridge/amd/pi/hudson/Makefile.inc:
Patch Set #47, Line 81: "3rdparty/blobs/southbridge/amd/avalon/PSP"
Again, use a Kconfig option please.
File util/amdfwtool/amdfwtool.h:
Patch Set #47, Line 117: endif
#endif /* _AMD_FW_TOOL_H_ */
File util/amdfwtool/amdfwtool.c:
printf("-x | --xhci <FILE> Add XHCI blob\n");
printf("-i | --imc <FILE> Add IMC blob\n");
printf("-g | --gec <FILE> Add GEC blob\n");
Many old platforms only has these 3 binary to integrate. […]
Ack
Patch Set #39, Line 1456: exit(1);
I dont quite understand. […]
That's what I was thinking, yes. Generate a sample config file with just the possible values. Maybe it's not worth the trouble. I'll let you decide. If you decide to do it, that's for a future commit, so marking this as resolved.
File util/amdfwtool/amdfwtool.c:
Patch Set #47, Line 169: printf("-p | --load-mp2-fw Set if load MP2 firmare\n");
'firmare' may be misspelled - perhaps 'firmware'?
Good job, build bot.
To view, visit change 42859. To unsubscribe, or for help writing mail filters, visit settings.