Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47231 )
Change subject: soc/mediatek/mt8192: Add 4266Mbps flag for dpm ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/47231/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47231/1//COMMIT_MSG@7 PS1, Line 7: dpm What does dpm mean?
https://review.coreboot.org/c/coreboot/+/47231/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
PS1: Please remove execute permission.
https://review.coreboot.org/c/coreboot/+/47231/1/src/soc/mediatek/mt8192/dra... PS1, Line 35: SA_RESERVE_MODE_RK0 Align with &ch[chn]
https://review.coreboot.org/c/coreboot/+/47231/1/src/soc/mediatek/mt8192/dra... PS1, Line 40: SA_RESERVE_SUPPORT_4266 Align with &ch[chn]
https://review.coreboot.org/c/coreboot/+/47231/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/dramc_pi_api.h:
PS1: Please remove execute permission.
https://review.coreboot.org/c/coreboot/+/47231/1/src/soc/mediatek/mt8192/inc... PS1, Line 343: Remove the blank line unless there's a logical difference between the 2 groups.
https://review.coreboot.org/c/coreboot/+/47231/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/dramc_register_bits_def.h:
PS1: Please remove execute permission.